Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2517: Migrate to HL7 validator wrapper #168

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Apr 17, 2024

Summary

Migrates from the original Inferno validator wrapper to the new HL7 validator wrapper. There should be no visible difference in the results, and there should be no special customization or configuration needed to get anything working. However the validator UI is no longer available by default.

Unlike the g10 cutover which used an env var to toggle between the 2, this one is a complete transition, so for example things like the env vars are replaced instead of adding new ones.

Note that I did leave the old validator commented out in the docker-compose file and nginx config so that if someone wants to use the validator UI with US core preloaded, they can uncomment those. (Should I add a comment somewhere to explain that?)

There are a couple new error messages that don't show up on prod, but they do show up locally with the latest from main so I think the difference is just tx.fhir.org & caching related. The two messages I've seen are:

Code changes

  • Bumped inferno-core to get the "don't run validator job in test" fix
  • Added hl7 validator to docker-compose and nginx config, commented out old validator items
  • Changed validator block in test suite template to fhir_resource_validator, added igs. Renamed env vars
  • Moved the suite id line to before the fhir_resource_validator block because the validator implicitly references the suite id so it needs to be set
  • Added new message to ignore URL value '.*' does not resolve - this happens when the validator sees a URL and is configured not to fetch it, and was ignored natively in the Inferno validator but the HL7 validator doesn't expose the ability to ignore that so it has to be ignored in the test kit
  • validator.validate calling the HL7 wrapper doesn't return OperationOutcome, but there is a function to convert it to one

Testing Guidance

Since inferno-core was bumped, you may need to run db migrations.

@dehall dehall requested review from yunwwang and Jammjammjamm April 17, 2024 18:34
@dehall dehall marked this pull request as draft April 18, 2024 10:26
Copy link
Contributor

@yunwwang yunwwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested US Core v6.1.0 and v4.0.0. Results look good.

@dehall dehall marked this pull request as ready for review April 22, 2024 11:28
@dehall dehall merged commit 9477217 into main Apr 22, 2024
2 checks passed
@dehall dehall deleted the fi-2517-migrate-validator branch April 22, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants