-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-2792 Create US Core 7 Test Suite #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another spot where versions need updating:
lib/us_core_test_kit/custom_groups/smart_well_known_capabilities_test.rb
Outdated
Show resolved
Hide resolved
run_as_group: true | ||
group from: :smart_discovery_stu2 do | ||
run_as_group | ||
test from: 'us_core_smart_well_known_capabilities' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scopes_supported
exists in SMART App Launch v1, so I'm not sure whether this test should exist there too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the confusing part because all the scopes listed in that section are SMART v2 scopes. I am not sure if the intention is that only servers support SMART v2 are required to support scopes_supported
. I have raised a US Core JIRA to clarify that. (https://jira.hl7.org/browse/FHIR-46279)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to get added to the discovery group for ehr launch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests appear for all versions of US Core rather than only for US Core 7.
Moved both to Naming class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests need to be regenerated.
run_as_group: true | ||
group from: :smart_discovery_stu2 do | ||
run_as_group | ||
test from: 'us_core_smart_well_known_capabilities' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to get added to the discovery group for ehr launch.
a6186d0
to
a0df504
Compare
…es_test.rb Co-authored-by: Stephen MacVicar <[email protected]>
7c0faf8
to
a0d8105
Compare
Summary
Add US Core 7 Test Suite
Add "Additional US Core Requirements" test to SMART Discovery test group
Remove US Core 7 Ballot Test Suite
Testing Guidance
Run US Core 7 Test Suite.
Some tests may fail due to terminology issue from tx.fhir.server
Some tests may fail due to reference server data (tickets should be already created)