Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2792 Create US Core 7 Test Suite #184

Merged
merged 30 commits into from
Jul 18, 2024
Merged

FI-2792 Create US Core 7 Test Suite #184

merged 30 commits into from
Jul 18, 2024

Conversation

yunwwang
Copy link
Contributor

Summary

Add US Core 7 Test Suite
Add "Additional US Core Requirements" test to SMART Discovery test group
Remove US Core 7 Ballot Test Suite

Testing Guidance

Run US Core 7 Test Suite.
Some tests may fail due to terminology issue from tx.fhir.server
Some tests may fail due to reference server data (tickets should be already created)

@yunwwang yunwwang requested a review from Jammjammjamm June 26, 2024 17:39
Copy link
Contributor

@Jammjammjamm Jammjammjamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run_as_group: true
group from: :smart_discovery_stu2 do
run_as_group
test from: 'us_core_smart_well_known_capabilities'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scopes_supported exists in SMART App Launch v1, so I'm not sure whether this test should exist there too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the confusing part because all the scopes listed in that section are SMART v2 scopes. I am not sure if the intention is that only servers support SMART v2 are required to support scopes_supported. I have raised a US Core JIRA to clarify that. (https://jira.hl7.org/browse/FHIR-46279)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to get added to the discovery group for ehr launch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests appear for all versions of US Core rather than only for US Core 7.

@yunwwang
Copy link
Contributor Author

yunwwang commented Jul 2, 2024

There's another spot where versions need updating:

https://github.com/inferno-framework/us-core-test-kit/blob/main/lib/us_core_test_kit/generator/search_test_generator.rb#L211-L218

Moved both to Naming class

Copy link
Contributor

@Jammjammjamm Jammjammjamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests need to be regenerated.

run_as_group: true
group from: :smart_discovery_stu2 do
run_as_group
test from: 'us_core_smart_well_known_capabilities'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to get added to the discovery group for ehr launch.

@yunwwang yunwwang force-pushed the FI-2792-us-core-7 branch from a6186d0 to a0df504 Compare July 3, 2024 16:47
@yunwwang yunwwang force-pushed the FI-2792-us-core-7 branch from 7c0faf8 to a0d8105 Compare July 18, 2024 13:42
@yunwwang yunwwang merged commit 4d7a070 into main Jul 18, 2024
2 checks passed
@yunwwang yunwwang deleted the FI-2792-us-core-7 branch July 18, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants