FI-3059 MustSupport Choice between Practitioner.address and PractitionerRole #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunwwang
force-pushed
the
FI-3059-practitioner-location
branch
from
102f75c to
b7d209c
Compare
| target_profile_with_version = "http://hl7.org/fhir/us/core/StructureDefinition/us-core-practitionerrole|#{metadata.profile_version}" | ||
|
|
||
| practitioner_roles.any? do |pr| | ||
| validator_response = validator.validate(pr, target_profile_with_version) |
There was a problem hiding this comment.
We need to unify this validation code and the validation code in the reference resolution test: https://github.com/inferno-framework/us-core-test-kit/blob/main/lib/us_core_test_kit/reference_resolution_test.rb#L159
Jammjammjamm
approved these changes
Oct 2, 2024
| end | ||
| end | ||
|
|
||
| messages = [] |
There was a problem hiding this comment.
I think from here down should just be:
missing_must_support_message = <<~MESSAGE
Could not find US Core PractitionerRole...in US Core Practitioner Profile
Resources. Please use patients with more information.
MESSAGE
assert @missing_elements.blank?, missing_must_support_message* auto generate practitioner_address_test for each allowed version * remove commented codes --------- Co-authored-by: Yunwei Wang <>
|
Refactored to automate practitioner_address_test generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes GitHub Issue onc-healthit/onc-certification-g10-test-kit#559
Changes:
Testing Guidance
Inferno Reference Server does not support this use case, ie Practitioner does not have address but there is PractitionerRole references this Practitioner
There are three unit tests covers this use case.