Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3060 Add MustSuport choice for Observation.effective[x] #199

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

yunwwang
Copy link
Contributor

@yunwwang yunwwang commented Sep 9, 2024

Summary

This PR fixed this Github issue: onc-healthit/onc-certification-g10-test-kit#560

Changes:

  • Remove MustSupport slice: effectiveDateTime
  • Add MustSuport element: effective[x]
  • Add version specific error fileter to allow effectivePeriod

Testing Guidance

Current Inferno reference server does not have effectivePeriod for SmokingStatus. Will update server data to support this test case.

@yunwwang yunwwang force-pushed the FI-3060-effective-period branch from 9c1b742 to f88beeb Compare September 10, 2024 15:05
@@ -44,7 +44,11 @@ module USCoreTestKit
%r{Observation.component\[\d+\].value.ofType\(Quantity\): The code provided \(http://unitsofmeasure.org#L/min\) was not found in the value set 'Vital Signs Units'} # Known issue with the Pulse Oximetry Profile
].freeze

VERSION_SPECIFIC_MESSAGE_FILTERS = <%=version_specific_message_filters%>.freeze
VERSION_SPECIFIC_MESSAGE_FILTERS = <%= if version_specific_message_filters.empty?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditions in ERB should generally be like this rather than wrapping everything in a single ERB tag:

<% if %>
  some text
<% else %>
  some other text
<% end %>

@yunwwang yunwwang merged commit 653a58c into main Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants