Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3354 Remove duplicate id in US Core Test Kit #204

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

yunwwang
Copy link
Contributor

Summary

US Core v3.1.1 has a special CapabilityStatement resource support test which verifies that server suports at least Patient + 1 resources. For US Core v4.0.0, this requirement is changed to server supports US Core Patient + 1 US Core profiles. The orginal resource support test for US Core v311 test suite accidentally had the same id as the one in US Core v4+ test suite.

Change Log:

  • Rename v3.1.1's profile_support_test.rb to resource_support_test.rb
  • Change the test id for resource_support_test to match version and purpose

Testing Guidance

  • All unit test shall pass
  • Running US Core 3.1.1 test suite using default reference server. CapabilityStatement test group (test group 2.1) shall pass

@yunwwang yunwwang requested a review from Jammjammjamm October 28, 2024 15:10
Copy link
Contributor

@Jammjammjamm Jammjammjamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change since it changes a test id.

@yunwwang yunwwang merged commit 233337e into main Oct 28, 2024
2 checks passed
@yunwwang yunwwang deleted the fi-3354-duplicated_id branch October 28, 2024 16:31
@yunwwang yunwwang changed the title Rename US Core v3.1.1 profile support test to resource support test FI-3354 Remove duplicate id in US Core Test Kit Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants