Add truncate function #2432
Open
Add truncate function #2432
+320
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the test_select file
JinHai-CN
reviewed
Jan 9, 2025
JinHai-CN
reviewed
Jan 9, 2025
| @@ -8,7 +8,8 @@ | |||
| python_executable = sys.executable | |||
|
|
|||
|
|
|||
| def python_sdk_test(python_test_dir: str, pytest_mark: str): | |||
| def python_sdk_test(python_test_dir: str, pytest_mark: str, single_file_name=""): | |||
JinHai-CN
reviewed
Jan 9, 2025
src/function/scalar/truncate.cpp
Outdated
| #include <cstddef> | ||
| #include <cmath> | ||
| #include <iostream> | ||
| #include <sstream> |
There was a problem hiding this comment.
Why some many headers need to include?
JinHai-CN
reviewed
Jan 9, 2025
| @@ -0,0 +1,63 @@ | |||
| // Copyright(C) 2023 InfiniFlow, Inc. All rights reserved. | |||
JinHai-CN
reviewed
Jan 9, 2025
src/function/scalar/truncate.cpp
Outdated
| @@ -0,0 +1,77 @@ | |||
|
|
|||
There was a problem hiding this comment.
Apache license information
JinHai-CN
reviewed
Jan 9, 2025
src/function/scalar/truncate.cpp
Outdated
| } else { | ||
|
|
||
| truncated_str = str.substr(0, i + right + 1); | ||
| std::cout << truncated_str << std::endl; |
JinHai-CN
reviewed
Jan 9, 2025
| import logical_type; | ||
| import internal_types; | ||
| import data_type; | ||
| #if 0 |
There was a problem hiding this comment.
Why ignore the unit test?
JinHai-CN
reviewed
Jan 9, 2025
JinHai-CN
reviewed
Jan 9, 2025
JinHai-CN
reviewed
Jan 9, 2025
python/test_pysdk/test_select.py
Outdated
| db_obj = self.infinity_obj.get_database("default_db") | ||
| db_obj.drop_table("test_select_truncate" + suffix, ConflictType.Ignore) | ||
| db_obj.create_table("test_select_truncate" + suffix, | ||
| {"c": {"type": "double"}}, ConflictType.Error) |
There was a problem hiding this comment.
Also need to check 'float' type data
…nction tests, the unit tests are remaining to be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add truncate function
Type of change