Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revertible in-memory store #159

Closed
rnbguy opened this issue Feb 22, 2024 · 0 comments · Fixed by #160
Closed

Revertible in-memory store #159

rnbguy opened this issue Feb 22, 2024 · 0 comments · Fixed by #160
Assignees
@rnbguy

Comments

@rnbguy
Copy link
Member

rnbguy commented Feb 22, 2024

The Store trait is already revertible friendly - by providing .reset() and .apply() methods. But these two are not implemented for InMemoryStore - rather it's extended via RevertibleStore.

It would be ideal if we leverage the original Store trait to implement a revertible InMemoryStore directly.

PS. RevertibleStore already has a non-terminating issue #129.
@rnbguy rnbguy self-assigned this Feb 22, 2024
@rnbguy rnbguy mentioned this issue Feb 22, 2024
Merged
@rnbguy rnbguy changed the title imp: revertible in-memory store Revertible in-memory store Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnbguy rnbguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revertible in-memory store informalsystems/basecoin-rs
1 participant
@rnbguy