-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revertible in-memory store #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sean Chen <[email protected]>
seanchen1991
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we address the len
method, I think this is good to go 👍
I like the expanded description of the problem you added to the PR description. I think the section on |
This was referenced May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159
Supports revertibility in in-memory store directly, without RevertibleStore wrapper.
Revert in
RevertibleStore
The old
RevertibleStore
relies on maintaining a list of processed operations -write
anddelete
. If it has to revert on a failed transaction, it tries to revert the previous operations.overwrite
,overwrite
with the old valuedelete
,insert
the old valueinsert
,delete
the current valueProblem
But this creates a problem with a deterministic Merkle root hash.
overwrite
-ing doesn't change the Merkle tree - butinsert
anddelete
may reorganize the Merkle tree. And we don't want to reorganize a Merkle tree on a failed transaction. That is, storage should have zero effect on a failed transaction.Also, we don't have deletion support until #141 is merged. This is why we have this non-termination bug present #129.
Revert in new
InMemoryStore
The new
InMemoryStore
has two copies of the current working store. These two copies arestaged
andpending
.Each transaction works on
pending
copy. When a transaction returns,pending
tostaged
.staged
topending
.When a block is committed, the staged copy is copied into the record of all committed stores.
Problem
This is not production-friendly. After each transaction, a whole store is copied from
pending
tostaged
orstaged
topending
.