Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for testing client recovery #176

Merged
merged 149 commits into from
Apr 26, 2024
Merged

Conversation

seanchen1991
Copy link
Contributor

Closes: #173

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen
rnbguy added 16 commits April 26, 2024 11:29

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep
nit

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added review comments.

Thanks for taking care of client recovery and transaction submission support ! 🚀

basecoin/modules/src/gov/impls.rs Show resolved Hide resolved
basecoin/modules/src/gov/impls.rs Outdated Show resolved Hide resolved
basecoin/src/tx/mod.rs Outdated Show resolved Hide resolved
basecoin/src/tx/mod.rs Outdated Show resolved Hide resolved
basecoin/src/tx/mod.rs Outdated Show resolved Hide resolved
basecoin/src/tx/mod.rs Show resolved Hide resolved
basecoin/src/cli/command.rs Outdated Show resolved Hide resolved
basecoin/src/tx/key_pair.rs Outdated Show resolved Hide resolved
basecoin/src/tx/key_pair.rs Outdated Show resolved Hide resolved
basecoin/src/tx/mod.rs Outdated Show resolved Hide resolved
rnbguy added 3 commits April 26, 2024 14:23

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep
@rnbguy
Copy link
Member

rnbguy commented Apr 26, 2024

Takes the latest commit from cosmos/ibc-rs#1197 to make sure e2e tests pass at basecoin-rs side 🚀

seanchen1991 and others added 6 commits April 26, 2024 09:16

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
seanchen1991 Sean Chen

Verified

This commit was signed with the committer’s verified signature.
rnbguy Rano | Ranadeep
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Sean ! 🚀

I updated the ibc-rs commit rev from main branch. When the CI passes, this can be merged.

@rnbguy rnbguy merged commit 8496b3f into main Apr 26, 2024
10 checks passed
@rnbguy rnbguy deleted the sean/client-recovery branch April 26, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feat) Integrate and test client recovery functionality
2 participants