Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ibc-proto v0.38.0 and remove unneeded object-safe trait definitions #3671

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Update to ibc-proto v0.38.0 and remove unneeded object-safe trait definitions #3671

merged 2 commits into from
Oct 20, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 20, 2023

Closes: #XXX

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from ljoss17 October 20, 2023 11:12
ljoss17
ljoss17 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great job!

@romac romac merged commit 5417c47 into master Oct 20, 2023
40 checks passed
@romac romac deleted the romac/ibc-proto-0.38 branch October 20, 2023 14:30
@romac romac mentioned this pull request Nov 9, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @ljoss17