Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mandatory type setting where missing in the guide #3679

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add mandatory type setting where missing in the guide #3679

merged 1 commit into from
Oct 25, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 25, 2023

Closes: #XXX

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from seanchen1991 October 25, 2023 13:55
@romac romac mentioned this pull request Oct 25, 2023
Merged
7 tasks
@seanchen1991 seanchen1991 merged commit 8bddbe5 into master Oct 25, 2023
3 checks passed
@seanchen1991 seanchen1991 deleted the romac/guide-update-type branch October 25, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanchen1991 seanchen1991 seanchen1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @seanchen1991