Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor VoteCount #15

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Refactor VoteCount #15

merged 5 commits into from
Oct 25, 2023

Conversation

romac
Copy link
Member

@romac romac commented Oct 25, 2023 •
edited
Loading

Simpler implementation, better aligned with #12

@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #15 (5688052) into romac/rust-state-machine (3fea113) will increase coverage by 2.29%.
The diff coverage is 97.01%.

@@                     Coverage Diff                      @@
##           romac/rust-state-machine      #15      +/-   ##
============================================================
+ Coverage                     83.12%   85.41%   +2.29%     
============================================================
  Files                            17       17              
  Lines                           794      891      +97     
============================================================
+ Hits                            660      761     +101     
+ Misses                          134      130       -4
Files Coverage Δ
Code/common/src/vote.rs 100.00% <ø> (ø)
Code/test/src/vote.rs 91.43% <100.00%> (-8.57%) ⬇️
Code/vote/src/count.rs 96.79% <100.00%> (+16.15%) ⬆️
Code/vote/src/lib.rs 92.86% <100.00%> (ø)
Code/consensus/src/executor.rs 88.64% <0.00%> (ø)
Code/vote/src/keeper.rs 65.91% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@romac romac merged commit cb1e259 into romac/rust-state-machine Oct 25, 2023
7 checks passed
@romac romac deleted the romac/vote-keeper-refactor branch October 25, 2023 17:13
romac added a commit that referenced this pull request Nov 8, 2023
@romac
Refactor VoteCount (#15)
2cdfb6a 
* Rename `check_threshold` to `is_threshold_met`

* Track nil as a regular value in the vote count

* Add unit test for `ValuesWeights`

* Remove dependency on `Consensus` trait in `VoteCount`

* Do not fail PRs on unexpected coverage changes not visible in diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romac