feat(code/example): Add metrics to the example app's store #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
added
work in progress
romac
changed the title
romac
changed the title
romac
force-pushed
the
romac/blockstore-metrics
branch
from
6c9e5dc to
9d3dcef
Compare
* added metrics to example store * optimized storing metrics in example app * added time observing metrics to example app * moving SharedRegistry import below * serving metrics in app_channel * renamed channel_app prefix from blockstore to app_channel * Handle errors in metrics server * Improve metrics collection in store * Formatting --------- Co-authored-by: Romain Ruetschi <[email protected]>
romac
removed
good first issue
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
- Coverage 76.87% 76.82% -0.05%
==========================================
Files 170 170
Lines 14389 14399 +10
==========================================
Hits 11061 11061
- Misses 3328 3338 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #635
PR author checklist