Propose checks, id in prevote and precommit #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## romac/consensus #7 +/- ##
====================================================
+ Coverage 71.49% 85.60% +14.11%
====================================================
Files 15 15
Lines 698 1007 +309
====================================================
+ Hits 499 862 +363
+ Misses 199 145 -54
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
romac
added a commit
that referenced
this pull request
Oct 24, 2023
* Propose checks, id in prevote and precommit * Disallow `unwrap` and `panic` * Add proper checks without unwraps * Add executor test with steps up to precommit * Formatting and clippy * Enable more lints * Finish the happy path test --------- Co-authored-by: Anca Zamfir <[email protected]>
romac
added a commit
that referenced
this pull request
Oct 24, 2023
* Add skeleton of consensus executor * Cleanup * Weight vote by its validators voting power * Add unit test for `ValidatorSet` * Split common lib into modules * WIP: Unit tests for state machine * Cleanup * Create new round state machine on NewRound * Propose checks, id in prevote and precommit (#7) * Propose checks, id in prevote and precommit * Disallow `unwrap` and `panic` * Add proper checks without unwraps * Add executor test with steps up to precommit * Formatting and clippy * Enable more lints * Finish the happy path test --------- Co-authored-by: Anca Zamfir <[email protected]> --------- Co-authored-by: Anca Zamfir <[email protected]>
18 tasks
romac
added a commit
that referenced
this pull request
Nov 8, 2023
* Add skeleton of consensus executor * Cleanup * Weight vote by its validators voting power * Add unit test for `ValidatorSet` * Split common lib into modules * WIP: Unit tests for state machine * Cleanup * Create new round state machine on NewRound * Propose checks, id in prevote and precommit (#7) * Propose checks, id in prevote and precommit * Disallow `unwrap` and `panic` * Add proper checks without unwraps * Add executor test with steps up to precommit * Formatting and clippy * Enable more lints * Finish the happy path test --------- Co-authored-by: Anca Zamfir <[email protected]> --------- Co-authored-by: Anca Zamfir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.