feat(spec): Requirements for the proposer selection algorithm #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josef-widder
approved these changes
Jan 10, 2025
specs/consensus/overview.md
Outdated
Comment on lines
483
to
484
| The [proposer selection procedure of CometBFT][cometbft-proposer], a Tendermint | ||
| implementation in Go, is a useful reference of how fairness can be achieved. |
There was a problem hiding this comment.
Should we mention (not explain) that Comet's proposer selection maintains priorities (I guess as part of the validator set) to achieve fairness?
There was a problem hiding this comment.
This is a good point. Refer to the quoted block that I have added with the reference to Comet and a minimal discussion regarding determinism and internal state of the algorithm.
I am trying to keep implementation details aside of this documentation, that is why I added this quoted block.
There was a problem hiding this comment.
Thanks for adding the paragraph. I contains just the right level of detail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #396.
Since some discussion in #388 have driven this requirements discussion, I have made some small changes to the
misbehavior.mdfile as well, in order to fully address the referenced issue.PR author checklist
For all contributors
For external contributors