feat(spec): discussion of consensus getValue() function
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
josef-widder
approved these changes
Jan 14, 2025
Comment on lines
+509
to
+510
| > A priori, every process running a consensus height could provide its proposed | ||
| > value for that height, but this approach has some disadvantages: |
There was a problem hiding this comment.
I wonder whether we should add a bullet point on the Starknet usecase, where it is expensive to compute a proposal (if it must contain a ZK proof), and therefore only the scheduled proposers of round 0 should do that to optimize on the normal case.
There was a problem hiding this comment.
Added a bullet point with this example.
Co-authored-by: Josef Widder <[email protected]> Signed-off-by: Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #761.
PR author checklist
For all contributors
For external contributors