feat(spec): Consensus timeouts and synchrony assumptions #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
josef-widder
approved these changes
Jan 15, 2025
specs/consensus/overview.md
Outdated
Comment on lines
730
to
731
| > Implementations could cancel scheduled timeouts when the state changes and | ||
| > the associated conditions are no longer observed. |
There was a problem hiding this comment.
I guess also when the process goes to the next round or if it decides and goes to the next height.
There was a problem hiding this comment.
I am explicitly citing the guard conditions, that are not detailed but explained in the previous paragraph.
Co-authored-by: Josef Widder <[email protected]> Signed-off-by: Daniel <[email protected]>
cason
requested review from
ancazamfir,
greg-szabo,
romac and
adizere
as code owners
cason
force-pushed
the
cason/761-timeouts
branch
from
379ea07 to
4fe9cdb
Compare
Co-authored-by: Josef Widder <[email protected]> Signed-off-by: Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #761.
Rendered section.
Probably it is better to merge this PR after PR #764.
PR author checklist
For all contributors
For external contributors