Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spec): Argue that Tendermint is a safe and live consensus algorithm #777

Merged
merged 36 commits into from
Jan 17, 2025
Merged

feat(spec): Argue that Tendermint is a safe and live consensus algorithm #777

merged 36 commits into from
Jan 17, 2025

Conversation

cason
Copy link
Contributor

@cason cason commented Jan 16, 2025 •
edited
Loading

Part of: #761.

Rendered section.

PR author checklist

For all contributors

For external contributors

cason added 25 commits January 14, 2025 21:06
@cason
spec/consensus: Gossip communication property
6b8064c
@cason
spec/consensus: communication property example
5515a2f
@cason
spec/consensus: gossip property simplified
faf6033
@cason
spec/consensus: footnote rephrased
f5b8cff
@cason
spec/consensus: pleasing the spell linter
17fa381
@cason
spec/consensus: timeout functions introduction
d2cd47c
@cason
spec/consensus: OnTimeout<Step> functions
2458c8b
@cason
spec/consensus: timeout<Step>(round) functions
f3f5964
@cason
spec/consensus: partially synchrony 101
d2f582f
@cason
spec/consensus: partially synchrony and timeouts
b7d1b54
@cason
spec/consensus: gossip property, Delta and GST
e0dbdc4
@cason
spec/consensus: Locking mechanism for correctness
311ed93
@cason
Merge branch 'main' into cason/761-correctness
42a83b5
@cason
spec/consensus: Locking mechanism section reviewed
94e91f3
@cason
spec/consensus: Valid value for liveness
f62b196
@cason
spec/consensus: Valid value scenarios
a9f287b
@cason
spec/consensus: Valid value scenarios nitpicks
f511db0
@cason
spec/consensus: Valid value with conclusion
dd1f59e
@cason
spec/consensus: Valid value description nitpicks
31061cf
@cason
spec/consensus: arguing safety of Tendermint
0e8a5c4
@cason
spec/consensus: argument for liveness, proposer side
919e133
@cason
spec/consensus: argument for liveness, nitpicks
e40276d
@cason
spec/consensus: liveness, test of numbered list
c113d86
@cason
spec/consensus: liveness, synchrony, GST, timeouts
513b008
@cason
spec/consensus: liveness and timeout precommit
5f5af89
@cason cason requested a review from josef-widder as a code owner January 16, 2025 13:16
@cason cason self-assigned this Jan 16, 2025
@cason cason added the spec Related to specifications label Jan 16, 2025
@cason cason mentioned this pull request Jan 16, 2025
Open
6 tasks
josef-widder
josef-widder approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@josef-widder josef-widder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially the discussions about lockedValue and validValue are super useful. I have suggested some additional text in the hope it improves readability.

specs/consensus/overview.md Outdated Show resolved Hide resolved
specs/consensus/overview.md Outdated Show resolved Hide resolved
specs/consensus/overview.md Outdated Show resolved Hide resolved
specs/consensus/overview.md Outdated Show resolved Hide resolved
specs/consensus/overview.md Show resolved Hide resolved
specs/consensus/overview.md Show resolved Hide resolved
cason and others added 10 commits January 16, 2025 18:48
@cason @josef-widder
Apply suggestions from @josef-widder
4f9ae1b 
Co-authored-by: Josef Widder <[email protected]>
Signed-off-by: Daniel <[email protected]>
@cason @josef-widder
Apply suggestions from @josef-widder
2fdf183 
Co-authored-by: Josef Widder <[email protected]>
Signed-off-by: Daniel <[email protected]>
@cason
spec/consensus: valid value, minor changes
ec07d42
@cason
spec/consensus: valid value, minor changes
c474aa5
@cason @josef-widder
Apply suggestions from @josef-widder
cf932b6 
Co-authored-by: Josef Widder <[email protected]>
Signed-off-by: Daniel <[email protected]>
@cason
spec/consensus: re-formatted liveness sub-section
f18e9ed
@cason
spec/consensus: correctness intro, small changes
2ab134a
@cason
spec/consensus: fighting against numbered lists
fff5412
@cason
spec/consensus: some reformatting in liveness section
bb52b2e
@cason
Merge branch 'main' into cason/761-correctness
9d649a8
@cason cason added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 775b934 Jan 17, 2025
2 checks passed
@cason cason deleted the cason/761-correctness branch January 17, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josef-widder josef-widder josef-widder approved these changes

Assignees

@cason cason

Labels
spec Related to specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cason @josef-widder