Skip to content

Commit

Permalink
Mention tx_max_bytes in the tutorials (tendermint#9809)
Browse files Browse the repository at this point in the history
Updates the discussion of prepareProposal in the go tutorials to mention tx_max_bytes limitation to transaction set size.



---

#### PR checklist

- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed
  • Loading branch information
lasarojc authored Dec 1, 2022
1 parent 739b92b commit ba84060
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion docs/tutorials/go-built-in.md
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,8 @@ When Tendermint Core sees that valid transactions (validated through `CheckTx`)
included in blocks, it groups some of these transactions and then gives the application a chance
to modify the group by invoking `PrepareProposal`.

The application is free to modify the group before returning from the call.
The application is free to modify the group before returning from the call, as long as the resulting set
does not use more bytes than `RequestPrepareProposal.max_tx_bytes'
For example, the application may reorder, add, or even remove transactions from the group to improve the
execution of the block once accepted.
In the following code, the application simply returns the unmodified group of transactions:
Expand Down
3 changes: 2 additions & 1 deletion docs/tutorials/go.md
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,8 @@ When Tendermint Core sees that valid transactions (validated through `CheckTx`)
included in blocks, it groups some of these transactions and then gives the application a chance
to modify the group by invoking `PrepareProposal`.

The application is free to modify the group before returning from the call.
The application is free to modify the group before returning from the call, as long as the resulting set
does not use more bytes than `RequestPrepareProposal.max_tx_bytes'
For example, the application may reorder, add, or even remove transactions from the group to improve the
execution of the block once accepted.
In the following code, the application simply returns the unmodified group of transactions:
Expand Down

0 comments on commit ba84060

Please sign in to comment.