remove grace period

inngest · Oct 8, 2024 · d22fbda · d22fbda
1 parent 091534d
commit d22fbda
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -67,6 +67,9 @@ jobs:
           # event key
           sed -i "s/REPLACE_EVENT_KEY/${{ secrets.INNGEST_EVENT_KEY }}/g" kustomization.yaml
 
+          # TLS cert
+          sed -i "s/REPLACE_TLS_CERT_ARN/${{ secrets.TLS_CERT_ARN }}/g" service.yaml
+
       - name: Deploy
         uses: ianbelcher/eks-kubectl-action@master # ALERT: master...?
         with:

diff --git a/deploy/deployment.yaml b/deploy/deployment.yaml
@@ -7,8 +7,6 @@ spec:
   revisionHistoryLimit: 5
   template:
     spec:
-      # allow enough time for graceful termination
-      terminationGracePeriodSeconds: 600
       topologySpreadConstraints:
         - topologyKey: "topology.kubernetes.io/zone"
           maxSkew: 1

diff --git a/deploy/service.yaml b/deploy/service.yaml
@@ -11,7 +11,7 @@ metadata:
     service.beta.kubernetes.io/aws-load-balancer-ssl-negotiation-policy: ELBSecurityPolicy-TLS13-1-2-2021-06
     service.beta.kubernetes.io/aws-load-balancer-attributes: load_balancing.cross_zone.enabled=true
     service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags: env=staging,app=rust-sdk
-    service.beta.kubernetes.io/aws-load-balancer-ssl-cert: arn:aws:acm:us-east-2:909933634258:certificate/56142e36-5123-47fc-90de-a2865439c6aa
+    service.beta.kubernetes.io/aws-load-balancer-ssl-cert: REPLACE_TLS_CERT_ARN
     # external DNS integration test
     external-dns.alpha.kubernetes.io/hostname: rust-sdk.inngest.net
 spec: