-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust/rbac-registration): refactoring #127
base: main
Are you sure you want to change the base?
Conversation
✅ Test Report | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌈
@@ -92,7 +107,13 @@ pub(crate) enum Cip509IntIdentifier { | |||
impl Decode<'_, ()> for Cip509 { | |||
fn decode(d: &mut Decoder, ctx: &mut ()) -> Result<Self, decode::Error> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metadata should take the paired transaction and witness set as context. Its not possible to decode properly without it, i don't think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is needed in validation and collecting the data for the registration chain.
rust/rbac-registration/src/cardano/cip509/utils/cip134/uri_set.rs
Outdated
Show resolved
Hide resolved
✅ Test Report | |
✅ Test Report | |
5fad6f6
to
a5af8a8
Compare
Description
Cip0134UriSet
type was added.Option<Vec<_>>
fields of theCip509RbacMetadata
structure were changed toVec<_>
.Related Issue(s)
Closes #104.
Related Pull Requests
This is a combination of the following pull requests:
Please confirm the following checks