fix(extension): avoid undefined form field passed to Buffer (#1592)

input-output-hk · Dec 16, 2024 · 7b37772 · 7b37772
1 parent 046f094
commit 7b37772
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/apps/browser-extension-wallet/src/features/dapp/components/SignData.tsx b/apps/browser-extension-wallet/src/features/dapp/components/SignData.tsx
@@ -10,6 +10,7 @@ import { Layout } from './Layout';
 import { useViewsFlowContext } from '@providers/ViewFlowProvider';
 import styles from './SignTransaction.module.scss';
 import { WalletType } from '@cardano-sdk/web-extension';
+import { createPassphrase } from '@lib/wallet-api-ui';
 
 export const SignData = (): React.ReactElement => {
   const { t } = useTranslation();
@@ -25,7 +26,7 @@ export const SignData = (): React.ReactElement => {
 
   const onConfirm = useCallback(async () => {
     setIsLoading(true);
-    const passphrase = Buffer.from(password.value, 'utf8');
+    const passphrase = createPassphrase(password);
     try {
       await request.sign(passphrase, { willRetryOnFailure: true });
       setValidPassword(true);

diff --git a/apps/browser-extension-wallet/src/features/dapp/components/SignTransaction.tsx b/apps/browser-extension-wallet/src/features/dapp/components/SignTransaction.tsx
@@ -12,6 +12,7 @@ import styles from './SignTransaction.module.scss';
 import { useAnalyticsContext } from '@providers';
 import { TX_CREATION_TYPE_KEY, TxCreationType } from '@providers/AnalyticsProvider/analyticsTracker';
 import { WalletType } from '@cardano-sdk/web-extension';
+import { createPassphrase } from '@lib/wallet-api-ui';
 
 export const SignTransaction = (): React.ReactElement => {
   const { t } = useTranslation();
@@ -35,7 +36,7 @@ export const SignTransaction = (): React.ReactElement => {
       [TX_CREATION_TYPE_KEY]: TxCreationType.External
     });
 
-    const passphrase = Buffer.from(password.value, 'utf8');
+    const passphrase = createPassphrase(password);
     try {
       await request.sign(passphrase, { willRetryOnFailure: true });
       setValidPassword(true);

diff --git a/apps/browser-extension-wallet/src/lib/wallet-api-ui.ts b/apps/browser-extension-wallet/src/lib/wallet-api-ui.ts
@@ -94,7 +94,7 @@ export const withSignTxConfirmation = async <T>(action: () => Promise<T>, passwo
  * @param {Partial<Password>} password The password object to be encoded.
  * @returns {Buffer} A Buffer containing the UTF-8 encoded password.
  */
-const createPassphrase = (password: Partial<Password>): Buffer => Buffer.from(password.value || '', 'utf8');
+export const createPassphrase = (password: Partial<Password>): Buffer => Buffer.from(password.value || '', 'utf8');
 
 /**
  * Handles the process of signing data with confirmation, supporting both in-memory and hardware wallets.