Feat/lw 12074 enable new input resolver in lace #1639
Draft
+345
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelCastilloB
force-pushed
the
feat/lw-12074-enable-new-input-resolver-in-lace
branch
3 times, most recently
from
2a3ed68 to
5ae6f1b
Compare
AngelCastilloB
force-pushed
the
feat/lw-12074-enable-new-input-resolver-in-lace
branch
from
5ae6f1b to
aafe57d
Compare
|
Allure Report
processReports: ✅ test report for aafe57d7
|
mkazlauskas
requested changes
Jan 10, 2025
| @@ -152,6 +173,16 @@ const walletFactory: WalletFactory<Wallet.WalletMetadata, Wallet.AccountMetadata | |||
| witnesser | |||
| } | |||
| ); | |||
|
|
|||
| if (inputResolver) { | |||
| inputResolver.setContext(sharedWallet); | |||
There was a problem hiding this comment.
(just an idea, not a change req) I think we had some kind of 'combineInputResolvers` function. It could be used instead of context approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Enable new Input resolver on Lace
Proposed solution
Add a new feature flag to toggle blockfrost input resolver on Lace