Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.py #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

client.py #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,17 @@ def getDataPoint(quote):
stock = quote['stock']
bid_price = float(quote['top_bid']['price'])
ask_price = float(quote['top_ask']['price'])
price = bid_price
price = (bid_price + ask_price)/2
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
price = (bid_price + ask_price)/2
price = (bid_price + ask_price)/2

return stock, bid_price, ask_price, price

def getRatio(price_a, price_b):
""" Get ratio of price_a and price_b """
""" ------------- Update this function ------------- """
""" Also create some unit tests for this function in client_test.py """
return 1
if(price_b == 0):
#where price_b is 0 avoid throwing ZeroDivisionError
return
return price_a/price_b

# Main
if __name__ == "__main__":
Expand All @@ -52,8 +55,10 @@ def getRatio(price_a, price_b):
quotes = json.loads(urllib2.urlopen(QUERY.format(random.random())).read())

""" ----------- Update to get the ratio --------------- """
prices = {}
for quote in quotes:
stock, bid_price, ask_price, price = getDataPoint(quote)
prices[stock] = price
print "Quoted %s at (bid:%s, ask:%s, price:%s)" % (stock, bid_price, ask_price, price)

print "Ratio %s" % getRatio(price, price)
print "Ratio %s" % getRatio(prices['ABC'],prices['DEF'])