improve stability #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scriptprivate
commented
Aug 13, 2024
scriptprivate
commented
- added unit tests
- fixed linter alerts
- updated workflows
- replace 'return;' with 'return 1;' to prevent 'undef' from being passed to 'exit', as undef is not a valid exit status
- refactor 'Threshold checking' subtest to check for returned code instead of exception - update 'Threshold checking' subtest to use 'is' function from Test::More - capture return value of 'main' function using 'scalar(main())' - check if return value is non-zero when threshold is exceeded, and zero when not exceeded
- introduce TEST_MODE environment variable check - modify script execution flow based on TEST_MODE - allow main() to run without exiting in test mode - maintain normal exit behavior for non-test execution
- add TEST_MODE=1 setting before requiring the main script - ensure tests can run without triggering script exit - improve test isolation and control over script behavior
- add debug statements for severity counts, limits and threshold checks - improve error handling for API request failures - refactor threshold checking logic - add more detailed output for threshold violations
- add test for invalid token or repository - add test for empty response from GitHub API - add test for multiple severity thresholds
|
Feel free to update the version of security-gate in the future PRs ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.