Add: frontier_silicon.js, sma-em.js, speedwire.js #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES: This PR includes detector modules for the sma-em and frontier_silicon community adapters.
Also included is a SMA speedwire method module.
The sma-em detector module requires the v1.0.0 of the sma-em adapter
(currently in "latest" see: https://github.com/iobroker-community-adapters/ioBroker.sma-em )
The frontier_silicon detector module requires the v0.1.1 of the frontier_silicon adapter
(currently in "latest" see: https://github.com/iobroker-community-adapters/ioBroker.frontier_silicon.git )
Known problems:
The frontier_silicon detector has the type "upnp". Currently the upnp method does not reliably find all ssdp servers in the network (see: upnp method does not reliably find all ssdp servers in the network #278 ).
Attention: A possible patch to the upnp method to fix upnp method does not reliably find all ssdp servers in the network #278 is included in this PR.
The frontier_silicon detector tries to set a default PIN for the adapter instance in order to ensure a smooth startup of the adapter. But because the PIN needs to be encrypted, startup of the instance fails and the user has to manually set the PIN.
It would be desirable if the discovery adapter would provide an encryption function
(see: discovery should save passwords encrypted #111 ).
The speedwire method is not needed by the sma-em detector module since the latter has the type "once" and
it can discover all energy meter IPs on it's own by listening to the multicast messages
of the energy meters just once for a period of 2 s.
However, the speedwire method might be useful for other SMA adapters like ioBroker.speedwire.
Known problems: If instances of sma-em are already running, the speedwire method will not discover any SMA speedwire devices.