GUI fixes #290
Merged
GUI fixes #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 8 out of 23 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- src-admin/package-lock.json: Language not supported
- src-admin/package.json: Language not supported
- src-admin/src/i18n/de.json: Language not supported
- src-admin/src/i18n/en.json: Language not supported
- src-admin/src/i18n/es.json: Language not supported
- src-admin/src/i18n/fr.json: Language not supported
- src-admin/src/i18n/it.json: Language not supported
- src-admin/src/i18n/nl.json: Language not supported
- src-admin/src/i18n/pl.json: Language not supported
- src-admin/src/i18n/pt.json: Language not supported
- src-admin/src/i18n/ru.json: Language not supported
- src-admin/src/Tabs/Options.tsx: Evaluated as low risk
- src-admin/src/components/DeviceEditDialog.tsx: Evaluated as low risk
- src-admin/src/components/QrCodeDialog.tsx: Evaluated as low risk
- src-admin/src/components/WelcomeDialog.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)
src-admin/src/Tabs/Controller.tsx:530
- [nitpick] If neither manualCode nor qrCode is provided, the dialog is closed without any action. This might be intended, but it should be confirmed.
onClose={async (manualCode?: string, qrCode?: string): Promise<void> => {
src-admin/src/Tabs/Controller.tsx:122
- [nitpick] The type CommissionableDevice | null | true for showQrCodeDialog is ambiguous. Consider using a more descriptive type.
showQrCodeDialog: CommissionableDevice | null | true;
Apollon77
approved these changes
Jan 7, 2025
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.