Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 09.01.25 #293

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Update 09.01.25 #293

merged 6 commits into from
Jan 9, 2025

Conversation

Apollon77
Copy link
Collaborator

  • Fixed Generic Switch Device type for controller
  • Fixed Controller BLE initialization and activation
  • (Added serialNumber to all devices and bridges for better device re-detection by controllers

@GermanBluefox GermanBluefox requested a review from Copilot January 9, 2025 09:31
Copy link
Contributor

@GermanBluefox GermanBluefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • package.json: Language not supported
  • README.md: Evaluated as low risk
  • src/matter/to-iobroker/GenericSwitchToIoBroker.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/matter/BridgedDevicesNode.ts:195

  • The change in the uniqueId extraction method could cause issues. Previously, it was extracting the last part of the UUID after splitting by a dot. Now, it just removes the dashes. This could change the behavior of the uniqueId.
const uniqueId = this.#parameters.uuid.replace(/-/g, '');
@Apollon77 Apollon77 merged commit bae7df0 into main Jan 9, 2025
22 checks passed
@Apollon77 Apollon77 deleted the upd090125 branch January 9, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants