Improve docker build workflow in forks #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using hardcoded image name, take it from the repo name. This makes it work well for forks.
isZumpo
requested review from
65278,
avorima,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
🚀 e2e tests runWe add labels to the PRs to control the e2e test runs by running specific tests and skipping some test contexts,
ℹ️ Ask a |
mcbenjemaa
reviewed
Nov 27, 2024
|
@mcbenjemaa i have to disagree with you here. I think the proposed change makes a lot of sense, since it allows contributors to more easily verify their changes in their repos, before submitting them to us. |
mcbenjemaa
added
the
e2e/none
|
@isZumpo can you check the actionlint |
wikkyk
requested changes
Nov 27, 2024
|
mcbenjemaa
approved these changes
Nov 27, 2024
|
Glad to see that the PR managed to get positive feedback and fixes commited and even a merge. All while I was away at work. Great work and thanks to everyone 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When forking the repository for development purposes, the github action workflow inside the fork will try upload the built image to ghcr.io/ionos-cloud/cluster-api-provider-proxmox, which results in a permission error:
ERROR: denied: permission_denied: The requested installation does not exist.This can be avoided by instead of having a hardcoded image name in the workflow, one dynamically takes the GITHUB_REPOSITORY variable and converts it into lowercase (for those who have Github usernames with one or more capital letters). Consequentially, every fork will push to its own registry without permission issues, while the main repository keeps working just like before.
Testing performed:
Verified workflow in my fork. It manages to publish ghcr images to my fork/registry.