Feat/implement volume boot order #486
Conversation
ionoscloud/resource_server.go
Outdated
| inlineVolumeIds := d.Get("inline_volume_ids") | ||
|
|
||
| if inlineVolumeIds != nil { | ||
| inlineVolumeIds := inlineVolumeIds.([]interface{}) |
There was a problem hiding this comment.
very minor, but you can use any instead of interface{}
There was a problem hiding this comment.
currently there is mixed usage of interface{} and any, should we allow this or enforce one over the other?
There was a problem hiding this comment.
we can allow for now. any was added in go 1.18. maybe we do a search and replace at some point.
ionoscloud/resource_server.go
Outdated
| volumes = append(volumes, entry) | ||
| if err := d.Set("volume", volumes); err != nil { | ||
| return fmt.Errorf("error setting volume %w", err) | ||
| bootOrder := "" |
There was a problem hiding this comment.
Can't you just set it to AUTO here and not have the if if bootOrder == "" below?
There was a problem hiding this comment.
has been reworked, we will now use a boolean instead of predefined strings like 'AUTO', 'NONE', 'PRIMARY'
| @@ -352,6 +360,15 @@ func resourceCubeServer() *schema.Resource { | |||
| }, | |||
| }, | |||
| }, | |||
| //Keep track of the inline volume of the Cube server in case the boot volume is changed. | |||
| "inline_volume_ids": { | |||
There was a problem hiding this comment.
Can you test an upgrade pre to after inline_volume_ids? I think we need to add something similar to resoruce_server
// takes care of an upgrade from a version that does not have inline_volume_ids(pre 6.4.0)
// to one that has it(>6.4.0)
if _, ok := d.GetOk("inline_volume_ids"); !ok {
if bootVolumeItf, ok := d.GetOk("boot_volume"); ok {
bootVolume := bootVolumeItf.(string)
var inlineVolumeIds []string
inlineVolumeIds = append(inlineVolumeIds, bootVolume)
if err := d.Set("inline_volume_ids", inlineVolumeIds); err != nil {
return utils.GenerateSetError("server", "inline_volume_ids", err)
}
}
}
There was a problem hiding this comment.
tested upgrade from 6.3.8 to current, seems to be working fine
ionoscloud/resource_server.go
Outdated
| @@ -310,6 +310,13 @@ func resourceServer() *schema.Resource { | |||
| Description: "The UUID of the attached server.", | |||
| Computed: true, | |||
| }, | |||
| "boot_order": { | |||
There was a problem hiding this comment.
can you add this to some server tests also?
There was a problem hiding this comment.
added tests for server resource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing this as the feature has been implemented by |
What does this fix or implement?
Ability to select the primary boot volume for
ionoscloud_serverChecklist
feat:/fix:/doc:/test:/refactor:)