Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Fix output of iota validator make-validator-info #4753

Open
wants to merge 11 commits into
base: core-protocol/procotol-version-4
Choose a base branch
from
Open

fix(node): Fix output of iota validator make-validator-info #4753

wants to merge 11 commits into from

Conversation

gokhan-simsek-iota
Copy link
Contributor

@gokhan-simsek-iota gokhan-simsek-iota commented Jan 13, 2025 •
edited by muXxer
Loading

Description of change

Changing primary_address to use tcp instead of udp and adding ip4/ip6/dns support for the output file validator.info of iota validator make-validator-info cmd. More info also here: #4437

Links to any relevant issues

Fixes: #4437 Fix output of iota validator make-validator-info

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Check validator.info after each time running the cmds below, make sure primary_address uses tcp instead of udp and all addresses use this multiaddr format ip4/ip6/dns correctly depending on the address input of the cmd.

// dns
cargo r -p iota -- validator make-validator-info validator0 description https://iota.org/logo.png https://www.iota.org localhost 1000

// ip4
cargo r -p iota -- validator make-validator-info validator0 description https://iota.org/logo.png https://www.iota.org 127.0.0.1 1000

// ip6
cargo r -p iota -- validator make-validator-info validator0 description https://iota.org/logo.png https://www.iota.org 1000:0ac3:22a2:0000:0000:4b3c:0504:1234 1000

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • (we need a local script version of CI checks) I have checked that new and existing unit tests pass locally with my changes

@iota-ci iota-ci added core-protocol node Issues related to the Core Node team labels Jan 13, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ❌ Failed (Inspect) Jan 18, 2025 11:02am
apps-ui-kit ❌ Failed (Inspect) Jan 18, 2025 11:02am
rebased-explorer ❌ Failed (Inspect) Jan 18, 2025 11:02am
wallet-dashboard ❌ Failed (Inspect) Jan 18, 2025 11:02am

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@gokhan-simsek-iota gokhan-simsek-iota mentioned this pull request Jan 14, 2025
Closed
5 tasks
@muXxer muXxer force-pushed the core-node/fix-make-validator-info-2 branch from d6c17fb to 41c66fc Compare January 14, 2025 18:23
@muXxer muXxer requested a review from a team as a code owner January 14, 2025 18:23
@muXxer muXxer changed the base branch from develop to core-protocol/procotol-version-3 January 14, 2025 18:23
@muXxer muXxer changed the title [DRAFT] fix(node): Fix output of iota validator make-validator-info fix(node): Fix output of iota validator make-validator-info Jan 14, 2025
@gokhan-simsek-iota gokhan-simsek-iota force-pushed the core-node/fix-make-validator-info-2 branch from 41c66fc to 703e53b Compare January 16, 2025 07:14
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 703e53b

✅ Preview: https://rebased-explorer-eez0d32cv-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 703e53b

✅ Preview: https://wallet-dashboard-gryd57cy2-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7c4f2ec

✅ Preview: https://rebased-explorer-ganwnd3pk-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7c4f2ec

✅ Preview: https://wallet-dashboard-6jyre2g9t-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 42c2b3d

✅ Preview: https://rebased-explorer-bybboyy6e-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 42c2b3d

✅ Preview: https://wallet-dashboard-p94fefeey-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muXxer muXxer muXxer requested changes

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@kodemartin kodemartin Awaiting requested review from kodemartin kodemartin is a code owner

@miker83z miker83z Awaiting requested review from miker83z miker83z is a code owner

Assignees
No one assigned
Labels
core-protocol documentation Improvements or additions to documentation node Issues related to the Core Node team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix output of iota validator make-validator-info
5 participants
@gokhan-simsek-iota @muXxer @lucas-tortora @iota-ci @DaughterOfMars