chore(ci): e2e changes #4892
Draft
chore(ci): e2e changes #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thibault-martinez
commented
Jan 17, 2025
•
thibault-martinez
commented
- Don't trigger it on rust changes in PRs
- Add manual trigger
- Don't run it on develop
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
iota-ci
added
dev-tools
thibault-martinez
requested review from
msarcev,
alexsporn,
DaughterOfMars and
Dr-Electron
as code owners
| @@ -33,7 +34,7 @@ jobs: | |||
| # Run e2e test against localnet built on the develop branch | |||
| localnet: | |||
| name: Localnet | |||
| if: inputs.isExplorer || inputs.isTypescriptSDK || inputs.isWallet || inputs.isRust || github.ref_name == 'develop' | |||
| if: inputs.isExplorer || inputs.isTypescriptSDK || inputs.isWallet || github.ref_name == 'develop' | |||
There was a problem hiding this comment.
Suggested change
| if: inputs.isExplorer || inputs.isTypescriptSDK || inputs.isWallet || github.ref_name == 'develop' | |
| if: inputs.isExplorer || inputs.isTypescriptSDK || inputs.isWallet |
@DaughterOfMars should we also do this?
There was a problem hiding this comment.
Or would it prevent it from running from the nightly workflow?
There was a problem hiding this comment.
It would prevent it from running in nightly, yes
There was a problem hiding this comment.
But does leaving it means it will run on pushes to develop?
There was a problem hiding this comment.
I guess not because it won't be called by the hierarchy?
Thoralf-M
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.