Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xtext grammar and reference node in process #194

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ Package_Impl returns Package:
('fromGitRepo:' fromGitRepo=EString)?
('specs:'
BEGIN
spec+=SpecBase*
PreListElement spec+=SpecBase
(PreListElement spec+=SpecBase)*
END
)?
('dependencies:' '[' dependency+=Dependency (',' dependency+=Dependency)* ']' )?
Expand Down Expand Up @@ -72,44 +73,43 @@ Artifact returns Artifact:

Node returns Node:
'node:' name=RosNames
BEGIN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this "BEGIN" removed intentionally? why?
The interfaces should be defined under the node.

(
('publishers:'
BEGIN
publisher+=Publisher*
END
)|
('subscribers:'
BEGIN
subscriber+=Subscriber*
END
)|
('serviceservers:'
BEGIN
serviceserver+=ServiceServer*
END
)|
('serviceclients:'
BEGIN
serviceclient+=ServiceClient*
END
)|
('actionservers:'
BEGIN
actionserver+=ActionServer*
END
)|
('actionclients:'
BEGIN
actionclient+=ActionClient*
END
)|
('parameters:'
BEGIN
parameter+=Parameter*
END
)
)*END
(
('publishers:'
BEGIN
publisher+=Publisher*
END
)|
('subscribers:'
BEGIN
subscriber+=Subscriber*
END
)|
('serviceServers:'
BEGIN
serviceserver+=ServiceServer*
END
)|
('serviceClients:'
BEGIN
serviceclient+=ServiceClient*
END
)|
('actionServers:'
BEGIN
actionserver+=ActionServer*
END
)|
('actionClients:'
BEGIN
actionclient+=ActionClient*
END
)|
('parameters:'
BEGIN
parameter+=Parameter*
END
)
)*
;

///////////////////
Expand Down Expand Up @@ -146,7 +146,7 @@ ActionSpec returns ActionSpec:

MessageDefinition returns MessageDefinition:
{MessageDefinition}
MessagePart+=MessagePart*;
MessagePart+=MessagePart+;

///////////////////
//INTERFACES
Expand Down