feat: introduce feature to limit integer to i64 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the IPLD Integer kind is represented internally as an `i128`. Serde has problems with untagged enums that contain i128 types. Therefore a feature flag called `integer-max-i64` is introduced, which reduces the internal integer representation to `i64`. This flag should be used with caution as e.g. not all valid DAG-CBOR data can now be represented. Closes #19.
sugyan
reviewed
Sep 3, 2024
Cargo.toml
Outdated
| @@ -20,6 +20,10 @@ serde = ["dep:serde", "dep:serde_bytes", "cid/serde"] | |||
| arb = ["dep:quickcheck", "cid/arb"] | |||
| # Enables support for the Codec trait, needs at least Rust 1.75 | |||
| codec = [] | |||
| # Makes the internal representation of an IPLD integer an `i64` instead of the default `i128`. This | |||
| # is usefult to work around Serde limitations in regards to untagged enums that contain `i128` | |||
|
One more thing to consider: Two feature flags that explicitly conflict at compile time with a compiler error.
That way, if someone pulls in the "default features", they'll never be surprised by someone else pulling in |
|
Note: I'd say that if neither feature is used, we should default to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the IPLD Integer kind is represented internally as an
i128. Serde has problems with untagged enums that contain i128 types. Therefore a feature flag calledinteger-max-i64is introduced, which reduces the internal integer representation toi64.This flag should be used with caution as e.g. not all valid DAG-CBOR data can now be represented.
Closes #19.