Replace libreadline with libedit on all platforms #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
force-pushed
the
libedit
branch
2 times, most recently
from
8c8229f to
48b7c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by usngo/iraf/iraf-v218!1, this PR consistently uses libedit instead of readline on all platforms. While this does not cause a change for the end user, it has a few advantages:
mkpkgfilelibedit and readline are (for the functionality we need in IRAF) API compatible. We use libedit already since ~2018 for macOS; see iraf-community/iraf#57.
One visible difference is that libedit silently ignores non-ASCII characters, i.e. they cannot be inserted. Reason is that libedit is explicitly unicode aware, and the its "readline" interface removes all non-ASCII characters. As IRAF cannot handle Unicode properly anyway, this may be OK.