Remove VMcache client from IRAF #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2024 21:33
修改： unix/os/zfdele.c 修改： unix/os/zfiobf.c
Closed
olebole
reviewed
Nov 14, 2024
.github/workflows/citest.yml
Outdated
| @@ -1,7 +1,7 @@ | |||
|
|
|||
| name: IRAF CI test | |||
|
|
|||
| on: [push, pull_request] | |||
| on: [push, pull_request, workflow_dispatch] | |||
There was a problem hiding this comment.
Just a change to my own repo, but somehow show up here.
|
One more comment: You didn't use a read e-mail address for the commits. This will make it hard to keep you linked to the change for proper contribution acknowledgement. This may be your intention, but if not you may better use a real e-mail (linked to your Github account or whatever) here. |
|
Consider all this. Maybe open a new pr is a better choice. I'd like to close this one and open a new one. |
|
You could also do a rebase and force-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the long-deprecated VMcache client from IRAF source code, avoiding the internet requests when launching IRAF.
Fixes: #415