Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing type export declaration in "exports" in package.json #138

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

parzhitsky
Copy link
Contributor

@parzhitsky parzhitsky commented Sep 30, 2024

An error appears when importing this package in a TypeScript project. Basically, it says that the types are there, but "exports" field doesn't mention them, so they can't be imported:

Could not find a declaration file for module 'node-web-audio-api'. 'path/to/node_modules/node-web-audio-api/index.mjs' implicitly has an 'any' type.
  There are types at 'path/to/node_modules/node-web-audio-api/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'node-web-audio-api' library may need to update its package.json or typings.ts(7016)
372068580-588cd423-7da7-4b1e-af3b-94843b8b23ac

This PR fixes that.

@parzhitsky parzhitsky changed the title fix/fix-missing-type-export-declaration Fix missing type export declaration in "exports" in package.json Sep 30, 2024
@b-ma
Copy link
Collaborator

b-ma commented Sep 30, 2024

Thanks!

@b-ma b-ma merged commit 1642635 into ircam-ismm:main Sep 30, 2024
5 checks passed
@parzhitsky parzhitsky deleted the patch-1 branch September 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants