[Dispatch] Enable fusing producers with scatter #19775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
force-pushed
the
enable_scatter_fusion
branch
3 times, most recently
from
1efaa5d to
9c12557
Compare
IanWood1
force-pushed
the
enable_scatter_fusion
branch
from
9c12557 to
17f51c1
Compare
IanWood1
requested review from
hanhanW,
MaheshRavishankar,
qedawkins,
kuhar and
Groverkss
as code owners
IanWood1
changed the title
|
|
IanWood1
force-pushed
the
enable_scatter_fusion
branch
from
17f51c1 to
02a32d6
Compare
…9198)" (iree-org#19535)" This reverts commit 07f81f0. Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
MaheshRavishankar
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable fusion of scatter with its producers.
Ignore the first commit as it is from @jerryyin's PR.indicesTesting with 8b unsharded, these changes result in fused rope + index computation as well as fused index computation. In the second case, the
updatesoperand was unable to fuse because work is needed to bubble reshapes through contractions (see first bullet in this issue #19752).