Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to create structure for alphabetical order of terms in non-English version #155

Merged

Conversation

ichsteffen
Copy link
Contributor

Approach as written in #152

This merge request includes:

  • a script to create language specific order of terms (alphabetical based on language specific term caption)
  • a new gradle task 'recreateTermStructures' to invoke script
  • a language specific structure file for German

… based on term caption)

Add a gradle task 'recreateTermStructures' to invoke script
Add a language specific structure file for german
@ichsteffen ichsteffen marked this pull request as ready for review November 20, 2022 18:27
Copy link
Collaborator

@programming-wolf programming-wolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert the script to a groovy one. You can use the learninggos script of the Advanced Template as inspiration.

build.gradle Outdated Show resolved Hide resolved
docs/1-terms/0-structure-DE.adoc Outdated Show resolved Hide resolved
@ichsteffen
Copy link
Contributor Author

I have no idea about groovy and gradle integration. Will take a second.

@ichsteffen ichsteffen marked this pull request as draft November 20, 2022 20:25
@programming-wolf
Copy link
Collaborator

No worries. We can look at it next week together if you like? 🙂

@ichsteffen
Copy link
Contributor Author

I replaced the bash script with a groovy script. The groovy script could be improved for sure (e.g. error checking).
But maybe it's good enough for the moment. At least it works on my computer ;)

@ichsteffen ichsteffen marked this pull request as ready for review November 21, 2022 09:17
Copy link
Collaborator

@programming-wolf programming-wolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive, yet I do have some requests for change. 😬

build.gradle Outdated Show resolved Hide resolved
scripts/sortTermsAlphabetically.gradle Show resolved Hide resolved
scripts/sortTermsAlphabetically.gradle Show resolved Hide resolved
scripts/sortTermsAlphabetically.gradle Show resolved Hide resolved
scripts/sortTermsAlphabetically.gradle Outdated Show resolved Hide resolved
- add documentation about general approach and about regex to extract term-anchor and captions
- make gradle tasks 'renderEN' and 'renderDE' dependent on task 'sortTermsAlphabetically'
- remove EMPTYRemark fragment
@programming-wolf
Copy link
Collaborator

Amazeballs, thank yoU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants