Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SDL_KeyCode in LEGO1.dll #51

Merged
merged 7 commits into from
Dec 29, 2024

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Dec 29, 2024

I think this change deserves its own pr for testing purposes.

  • Also use iniparser for getting mediaPath
  • and replace a single isdigit with SDL_isdigit

ISLE/isleapp.cpp Outdated Show resolved Hide resolved
@foxtacles
Copy link
Member

In the registration book, we have an access violation when trying to type a name:

image

Probably just need to replace the - 'A' part

@foxtacles
Copy link
Member

foxtacles commented Dec 29, 2024

The debug triggers behind the "ogel" password don't work right now - I think you have to replace the g_debugPassword with an array (null terminated) of the corresponding SDL key codes.

@madebr
Copy link
Contributor Author

madebr commented Dec 29, 2024

The debug triggers behind the "ogel" password don't work right now - I think you have to replace the g_debugPassword with an array (null terminated) of the corresponding SDL key codes.

Indeed. Long term, we should use a combination of SDL_Keycode and SDL_Scancode: SDL_Scancode for WASD and movement, and keycode for other cheats and/or text input.

@foxtacles
Copy link
Member

Everything works now, thank you!

@foxtacles foxtacles merged commit b97aea4 into isledecomp:master Dec 29, 2024
9 checks passed
@madebr madebr deleted the SDL_Keycode-all-the-way branch December 29, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants