Feature/8 #9
Merged
Feature/8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final String reference = correspondenceEntryBean.getReference(); | ||
| final CorrespondenceEntry entry = correspondenceEntryBean.getEntry(); | ||
|
|
||
| if (CollectionUtils.select(correspondenceEntryBean.getMailTracking().getActiveEntries(correspondenceType), |
There was a problem hiding this comment.
Common's CollectionUtils, while perfectly functional, should be avoided.
You could instead use Guava's Iterables class see here to perform this operation. It provides a much cleaner API, and lazily evaluates the collection, in a much more efficient manner.
Note that I am not saying you should change what you have done here, just leaving it for future reference :)
There was a problem hiding this comment.
I just saw it CollectionUtils was being used in some parts of the code, so I just followed it.
But I'll use Iterables next time, thanks for the tip ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #8.
Still can have issues if with the automatic number generator if the operator set the counters below the maximum number attributed at a given moment.
Fixing that problem would require a dangerous operation of looking at every entry present and check if the numbers already exist. However this implies a great change in the code which can lead to non desirable behaviours