Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: code block indentation workarounds #2458

Closed
wants to merge 2 commits into from
Closed

Conversation

jorgeorpinel
Copy link
Contributor

rel #1509

@shcheklein shcheklein temporarily deployed to dvc-org-start-dp-indent-iaadqm May 10, 2021 17:05 Inactive
Comment on lines -93 to +97
```yaml
prepare:
split: 0.20
seed: 20170428
```
```yaml
prepare:
split: 0.20
seed: 20170428
```
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to force commit this since Pretty doesn't like it (4-space indentation). Formatting check will prob. fail. But this looks correctly for now:

image

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-start-dp-indent-iaadqm May 10, 2021 17:28 Inactive
Comment on lines 107 to 113
```git
.
├── data
│ ├── data.xml
│ ├── data.xml.dvc
.
├── data
│ ├── data.xml
│ ├── data.xml.dvc
+│ └── prepared
+│ ├── test.tsv
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the workaround so it looks correct really makes the code looks broken. And the formatter doesn't catch this one. So I wonder if it's best to close this PR and focus on fixing #1509 instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT @shcheklein ?

BTW if so maybe I should remove all other workaround indentations that are currently in docs, e.g. in the remote modify ref there's several. Or we can do that after the bug is fixed (added a checkbox in that issue).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest looks like a minor problem, I would wait on the engine to fix this, for now broken it's fine to unindent code blocks

@jorgeorpinel jorgeorpinel changed the title start: workaround indent yaml block start: workaround indent code blocks May 10, 2021
@jorgeorpinel jorgeorpinel changed the title start: workaround indent code blocks start: code block indentation workarounds May 10, 2021
@jorgeorpinel jorgeorpinel deleted the start/dp-indent branch May 13, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants