-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start: code block indentation workarounds #2458
Conversation
```yaml | ||
prepare: | ||
split: 0.20 | ||
seed: 20170428 | ||
``` | ||
```yaml | ||
prepare: | ||
split: 0.20 | ||
seed: 20170428 | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```git | ||
. | ||
├── data | ||
│ ├── data.xml | ||
│ ├── data.xml.dvc | ||
. | ||
├── data | ||
│ ├── data.xml | ||
│ ├── data.xml.dvc | ||
+│ └── prepared | ||
+│ ├── test.tsv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the workaround so it looks correct really makes the code looks broken. And the formatter doesn't catch this one. So I wonder if it's best to close this PR and focus on fixing #1509 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT @shcheklein ?
BTW if so maybe I should remove all other workaround indentations that are currently in docs, e.g. in the remote modify
ref there's several. Or we can do that after the bug is fixed (added a checkbox in that issue).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest looks like a minor problem, I would wait on the engine to fix this, for now broken it's fine to unindent code blocks
rel #1509