Channel: Fetch header informations from homepage #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
changed the title
SamantazFox
approved these changes
Nov 8, 2023
SamantazFox
changed the title
SamantazFox
changed the title
ashley0143
added a commit
to ashley0143/poke
that referenced
this pull request
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4238
YouTube is removing the about tab from channels so Invidious can no longer utilize it to obtain basic channel information (title, banner, etc). This PR just switches the code to use the default homepage instead.
In the future we should try and look into a way to prevent making two requests to YouTube on the various pagination of the channel tabs. The simplest answer would probably be to just cache the results. But we should be able to optimize it to a single request on the initial page as the initial request also contains basic channel information we need.