bug-fix: fix fast-check discrepency (#132)

jacob-alford · Oct 24, 2022 · 8be1229 · 8be1229
1 parent 8665a9d
commit 8be1229
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/package.json b/package.json
@@ -89,7 +89,7 @@
     "eslint-import-resolver-typescript": "^3.1.1",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-simple-import-sort": "^7.0.0",
-    "fast-check": "^2.13.0",
+    "fast-check": "^3.1.4",
     "fp-ts": "^2.9.5",
     "fp-ts-laws": "^0.3.0",
     "glob": "^8.0.3",

diff --git a/src/number/NegativeFloat.ts b/src/number/NegativeFloat.ts
@@ -125,5 +125,5 @@ export const Encoder: SchemableParams2<Enc.URI> = Enc.id()
  * @category Instances
  */
 export const Arbitrary: SchemableParams1<Arb.URI> = fc
-  .float({ min: -Number.MAX_VALUE, max: 0 })
+  .float({ max: 0 })
   .filter(isNegativeFloat)
diff --git a/src/number/NonNegativeFloat.ts b/src/number/NonNegativeFloat.ts
@@ -125,5 +125,5 @@ export const Encoder: SchemableParams2<Enc.URI> = Enc.id()
  * @category Instances
  */
 export const Arbitrary: SchemableParams1<Arb.URI> = fc
-  .float({ min: 0, max: Number.MAX_VALUE })
+  .float({ min: 0 })
   .filter(isNonNegativeFloat)
diff --git a/src/number/NonPositiveFloat.ts b/src/number/NonPositiveFloat.ts
@@ -124,5 +124,5 @@ export const Type: SchemableParams1<t.URI> = pipe(
  * @category Instances
  */
 export const Arbitrary: SchemableParams1<Arb.URI> = fc
-  .float({ min: -Number.MAX_VALUE, max: 0 })
+  .float({ max: 0 })
   .filter(isNonPositiveFloat)
diff --git a/src/number/PositiveFloat.ts b/src/number/PositiveFloat.ts
@@ -125,5 +125,5 @@ export const Encoder: SchemableParams2<Enc.URI> = Enc.id()
  * @category Instances
  */
 export const Arbitrary: SchemableParams1<Arb.URI> = fc
-  .float({ min: 0, max: Number.MAX_VALUE })
+  .float({ min: 0 })
   .filter(isPositiveFloat)
diff --git a/src/string/HslColor.ts b/src/string/HslColor.ts
@@ -157,7 +157,7 @@ export const Arbitrary: SchemableParams1<Arb.URI> = fc
     fc.integer({ min: 0, max: 360 }),
     fc.integer({ min: 0, max: 100 }),
     fc.integer({ min: 0, max: 100 }),
-    fc.float()
+    fc.float({ noDefaultInfinity: true })
   )
   .map(
     ([hue, saturation, lightness, alpha]) =>

diff --git a/yarn.lock b/yarn.lock
@@ -3498,20 +3498,20 @@ extglob@^2.0.4:
     snapdragon "^0.8.1"
     to-regex "^3.0.1"
 
-fast-check@^2.13.0:
-  version "2.25.0"
-  resolved "https://registry.yarnpkg.com/fast-check/-/fast-check-2.25.0.tgz#5146601851bf3be0953bd17eb2b7d547936c6561"
-  integrity sha512-wRUT2KD2lAmT75WNIJIHECawoUUMHM0I5jrlLXGtGeqmPL8jl/EldUDjY1VCp6fDY8yflyfUeIOsOBrIbIiArg==
-  dependencies:
-    pure-rand "^5.0.1"
-
 fast-check@^3.0.0:
   version "3.1.4"
   resolved "https://registry.yarnpkg.com/fast-check/-/fast-check-3.1.4.tgz#e755623b4a63d0a26c285acbd1c1d8e3ea283a6e"
   integrity sha512-AC4o8U7riY668tHAcJ10PHWpmhaNDfyzs2THFwQ6FJMPP05EmHKEmYvup7B1DCS+kKAzzosjSF51TamUM5IyPA==
   dependencies:
     pure-rand "^5.0.2"
 
+fast-check@^3.1.4:
+  version "3.3.0"
+  resolved "https://registry.yarnpkg.com/fast-check/-/fast-check-3.3.0.tgz#002b7cc53166129545983ab4fe97a80fef6ac8b4"
+  integrity sha512-Zu6tZ4g0T4H9Tiz3tdNPEHrSbuICj7yhdOM9RCZKNMkpjZ9avDV3ORklXaEmh4zvkX24/bGZ9DxKKqWfXttUqw==
+  dependencies:
+    pure-rand "^5.0.2"
+
 fast-deep-equal@^3.1.1, fast-deep-equal@^3.1.3:
   version "3.1.3"
   resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-3.1.3.tgz#3a7d56b559d6cbc3eb512325244e619a65c6c525"
@@ -6290,7 +6290,7 @@ punycode@^2.1.0, punycode@^2.1.1:
   resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.1.1.tgz#b58b010ac40c22c5657616c8d2c2c02c7bf479ec"
   integrity sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A==
 
-pure-rand@^5.0.1, pure-rand@^5.0.2:
+pure-rand@^5.0.2:
   version "5.0.3"
   resolved "https://registry.yarnpkg.com/pure-rand/-/pure-rand-5.0.3.tgz#a2f15dfbc3be8433d1d8ed67ee411aa83fb90406"
   integrity sha512-9N8x1h8dptBQpHyC7aZMS+iNOAm97WMGY0AFrguU1cpfW3I5jINkWe5BIY5md0ofy+1TCIELsVcm/GJXZSaPbw==