TCK challenge against boolean result of Query #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rauh <[email protected]>
gavinking
reviewed
Jan 6, 2025
Co-authored-by: Gavin King <[email protected]>
otaviojava
reviewed
Jan 6, 2025
| * <p>For {@code update} or {@code delete} statements, the return value must be one of:</p> | ||
| * <ul> | ||
| * <li>{@code void}</li> | ||
| * <li>{@code int} or {@code long}, where the value is the number of matching entities</li> |
There was a problem hiding this comment.
Please only include that with a NoSQL database that works with eventual persistence; this value might not be as precise as an ACID database. Such as, a relational database.
There was a problem hiding this comment.
Sure, I added that in 111205c
otaviojava
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #923 by switching the TCK test from the invalid
booleanreturn value for@Query("UPDATE ...to instead have a return type ofint. Also, improves documentation ofQueryto clarify what theintandlongreturn values mean.A separate PR/issue should be used if we decide that we also want to support a boolean return type.