standardize on the term entity attribute #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rauh <[email protected]>
Signed-off-by: Nathan Rauh <[email protected]>
otaviojava
reviewed
Jan 10, 2025
| * @param <T> entity class of the sortable property. | ||
| * @param property the property name to order by | ||
| * @param <T> entity class of the sortable entity attribute. | ||
| * @param attributeName name of the entity attribute to order by |
There was a problem hiding this comment.
attributeNamesounds odd, why not just attribute?
There was a problem hiding this comment.
Thanks for the feedback. I can switch it to that. Here is the commit for it, d82c044
|
@njr-11 we agreed with |
otaviojava
reviewed
Jan 10, 2025
otaviojava
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #906
Updates existing Javadoc and spec doc to refer to use consistent terminology when referring to entity attributes/fields/properties.
Hopefully this will be easier for our users to understand because we will no longer be switching back and forth between entity attribute / field / property / fields and properties, and so forth everywhere, which gave the appearance of them being different things.