Fixed doc typos re: @Jsonb(De)Serializer #183
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes jakartaee#70 Signed-off-by: Markus KARG <[email protected]>
|
I marked this PR as a draft, as the spec source is not contained. Please tell me if I shall keep it in draft state until the spec source is available, or whether I shall turn it in a real PR so you could merge it. Thanks. :-) |
|
@aguibert You better ask Eclipse folks. They need to do some legal checks before allowing us using the old spec text. |
|
@m0mus Did EF already ask you for your approval of the spec? I was asked weeks ago and it seems nothing happend so far. So how to proceed? Keep the PR in draft state until we have the OK from the EF, or merge this PR, keep the issue open, and create another PR for the spec change? |
|
@mkarg No, I didn't have any request from EF regarding the spec. I suppose that it will happen after Jakarta EE 8 release. |
rmannibucau
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of #70 (JavaDocs only)
Unfortunately I could only fix the JavaDocs, as there is just boilerplate for the actual spec.