Review comments

jakartaee · Mar 20, 2024 · 4c2d374 · 4c2d374
1 parent 6964fd8
commit 4c2d374
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/jaxrs-api/src/main/java/jakarta/ws/rs/client/ClientRequestContext.java b/jaxrs-api/src/main/java/jakarta/ws/rs/client/ClientRequestContext.java
@@ -207,7 +207,7 @@ public default boolean hasProperty(String name) {
      * (missing comma), or the value {@code no - store} (whitespace within value).
      *
      * @param name the message header.
-     * @param valueSeparatorRegex String or regular expression that separates the header value into single values. 
+     * @param valueSeparatorRegex Regular expression that separates the header value into single values. 
      * {@code null} does not split.
      * @param valuePredicate value must fulfil this predicate.
      * @return {@code true} if and only if a header with the given name exists, having either a whitespace-trimmed value

diff --git a/jaxrs-api/src/main/java/jakarta/ws/rs/client/ClientResponseContext.java b/jaxrs-api/src/main/java/jakarta/ws/rs/client/ClientResponseContext.java
@@ -99,7 +99,7 @@ public interface ClientResponseContext {
      * (missing comma), or the value {@code no - store} (whitespace within value).
      *
      * @param name the message header.
-     * @param valueSeparatorRegex String or regular expression that separates the header value into single values. 
+     * @param valueSeparatorRegex Regular expression that separates the header value into single values. 
      * {@code null} does not split.
      * @param valuePredicate value must fulfil this predicate.
      * @return {@code true} if and only if a header with the given name exists, having either a whitespace-trimmed value

diff --git a/...tck/src/main/java/ee/jakarta/tck/ws/rs/api/client/clientrequestcontext/JAXRSClientIT.java b/...tck/src/main/java/ee/jakarta/tck/ws/rs/api/client/clientrequestcontext/JAXRSClientIT.java
@@ -882,7 +882,7 @@ protected void checkFilterContext(ClientRequestContext context) throws Fault {
           //Shouldn't find first value when separator character is incorrect
           assertFalse(context.containsHeaderString("header1", ";", "value1"::equalsIgnoreCase));
           //Test regular expression
-          assertFalse(context.containsHeaderString("header1", "; | ,", "value2"::equalsIgnoreCase));
+          assertFalse(context.containsHeaderString("header1", ";|,", "value2"::equalsIgnoreCase));
           //White space in value not trimmed
           assertFalse(context.containsHeaderString("header1", "whitespace"::equalsIgnoreCase));
           //Multiple character separator
@@ -904,7 +904,7 @@ protected void checkFilterContext(ClientRequestContext context) throws Fault {
     Response response = invoke(invocation);
 
     String entity = response.readEntity(String.class);
-    assertTrue(entity.contains("Sucess"));
+    assertTrue(entity.contains("Success"));
   }
 
 

diff --git a/...ck/src/main/java/ee/jakarta/tck/ws/rs/api/client/clientresponsecontext/JAXRSClientIT.java b/...ck/src/main/java/ee/jakarta/tck/ws/rs/api/client/clientresponsecontext/JAXRSClientIT.java
@@ -455,7 +455,7 @@ protected void checkFilterContext(ClientRequestContext requestContext,
               //Shouldn't find first value when separator character is incorrect
               assertFalse(responseContext.containsHeaderString("header1", ";", "value1"::equalsIgnoreCase));
               //Test regular expression
-              assertFalse(responseContext.containsHeaderString("header1", "; | ,", "value2"::equalsIgnoreCase));
+              assertFalse(responseContext.containsHeaderString("header1", ";|,", "value2"::equalsIgnoreCase));
               //White space in value not trimmed
               assertFalse(responseContext.containsHeaderString("header1", "whitespace"::equalsIgnoreCase));
               //Multiple character separator