Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not checking for unrar #19

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

nn9dev
Copy link

@nn9dev nn9dev commented Sep 11, 2019

i ran this for like 30 mins before i realised that i didn't have unrar installed. hopefully this helps people in the future.

@nn9dev
Copy link
Author

nn9dev commented Sep 11, 2019

nah travis hates me. i think it's a problem with 7z but i dunno

@jaredsburrows
Copy link
Owner

@nn9dev I believe you are almost there. It looks like 7z passed but now zip files fail?

@nn9dev
Copy link
Author

nn9dev commented Sep 13, 2019

if I was able to tell you what the error was here, i'd be all over it. I honestly do NOT know. if travis was more verbose when running commands and such then MAYBE but I have no idea what's up

@jaredsburrows
Copy link
Owner

Have you tried running your code locally? Then running the commands that travis is running locally?

@nn9dev
Copy link
Author

nn9dev commented Sep 13, 2019

It works perfectly fine on my end. I noticed in the Travis build that it doesn't either throw a confirm or an error for the 7z bit of code and so I made it return EXEC_FAILURE which maybe I shouldn't have done because if someone is trying to do a rar and doesn't have 7z then it just halts so maybe I'll revise that but if you can see a way to fix it on Travis I could try to fix that if you see it as necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants