-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Patch for client connection leak when using digest authentication #3546
Conversation
Hello - any updates? |
I made an additional change. I noticed that when a server returns 2 WWW-Authenticate headers, the first with Basic the second with Digest, the filter picks Basic even though Digest is stronger and therefore Digest should be used per https://tools.ietf.org/html/rfc2617#section-4.6 . I fixed that issue. |
@agherardi you could consider posting the other fix as another PR. Also, there is no test for the other change. And you are using different formatting that the rest of the code.. |
I'd prefer to keep one PR since both changes are for the same class. I added unit tests for both changes. i fixed the code formatting issue. |
I won't. Focused changes do help with the debugging in the future. Not to mention that the commit message doesn't say anything about the other change. |
I rolled back the 2nd change. I created a separate pull request for the 2nd change https://github.com/jersey/jersey/pull/3562 . Other than that, are you OK with changes + tests? |
Any updates? Thanks. |
Any updates? |
Replaced by https://github.com/jersey/jersey/pull/3751 |
No description provided.